Mercurial > vim

comparison src/testdir/test_ins_complete.vim @ 33713:9aa03e12b2b5 v9.0.2090

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
patch 9.0.2090: complete_info() skips entries with 'noselect' Commit: https://github.com/vim/vim/commit/57f9ce1a0977da13e5923214086795ffa2d28ce1 Author: Christian Brabandt <cb@256bit.org> Date: Sat Nov 4 09:58:14 2023 +0100 patch 9.0.2090: complete_info() skips entries with 'noselect' Problem: complete_info() skips entries with 'noselect' Solution: Check, if first entry is at original text state Unfortunately, Commit daef8c74375141974d61b85199b383017644978c introduced a regression, that when ':set completeopt+=noselect' is set and no completion item has been selected yet, it did not fill the complete_info['items'] list. This happened, because the current match item did not have the CP_ORIGINAL_TEXT flag set and then the cp->prev pointer did point to the original flag item, which caused the following while loop to not being run but being skipped instead. So when the 'noselect' is set, only start with to the previous selection item, if the initial completion item has the CP_ORIGINAL_TEXT flag set, else use the 2nd previous item instead. fixes: #13451 closes: #13452 Signed-off-by: Christian Brabandt <cb@256bit.org>
author Christian Brabandt <cb@256bit.org>
date Sat, 04 Nov 2023 10:15:04 +0100
parents 76ff7b7b44f2
children ac9356547a7b
comparison
equal deleted inserted replaced
33712:e09acb1daea7 33713:9aa03e12b2b5
2342 2342
2343 " Search backward. 2343 " Search backward.
2344 call feedkeys("Go\<C-X>\<C-P>\<F5>\<Esc>_dd", 'tx') 2344 call feedkeys("Go\<C-X>\<C-P>\<F5>\<Esc>_dd", 'tx')
2345 call assert_equal(-1, g:compl_info['selected']) 2345 call assert_equal(-1, g:compl_info['selected'])
2346 2346
2347 " Check if index out of range
2348 " https://github.com/vim/vim/pull/12971
2349 call feedkeys("Go\<C-X>\<C-N>\<C-P>\<F5>\<Esc>_dd", 'tx') 2347 call feedkeys("Go\<C-X>\<C-N>\<C-P>\<F5>\<Esc>_dd", 'tx')
2350 call assert_equal(0, g:compl_info['selected']) 2348 call assert_equal(0, g:compl_info['selected'])
2351 call assert_equal(6 , len(g:compl_info['items'])) 2349 call assert_equal(6 , len(g:compl_info['items']))
2352 call assert_equal("fff", g:compl_info['items'][g:compl_info['selected']]['word']) 2350 call assert_equal("fff", g:compl_info['items'][g:compl_info['selected']]['word'])
2353 call feedkeys("Go\<C-X>\<C-N>\<C-N>\<C-N>\<C-N>\<C-N>\<C-N>\<C-N>\<C-N>\<C-N>\<F5>\<Esc>_dd", 'tx') 2351 call feedkeys("Go\<C-X>\<C-N>\<C-N>\<C-N>\<C-N>\<C-N>\<C-N>\<C-N>\<C-N>\<C-N>\<F5>\<Esc>_dd", 'tx')
2354 call assert_equal("aaa", g:compl_info['items'][g:compl_info['selected']]['word']) 2352 call assert_equal("aaa", g:compl_info['items'][g:compl_info['selected']]['word'])
2355 call assert_equal(6 , len(g:compl_info['items'])) 2353 call assert_equal(6 , len(g:compl_info['items']))
2354 call feedkeys("Go\<C-X>\<C-N>\<F5>\<Esc>_dd", 'tx')
2355 call assert_equal(-1, g:compl_info['selected'])
2356 call assert_equal(6 , len(g:compl_info['items']))
2356 2357
2357 set completeopt& 2358 set completeopt&
2358 bwipe! 2359 bwipe!
2359 endfunc 2360 endfunc
2360 2361