comparison runtime/doc/change.txt @ 33776:9503dc55b5ed v9.0.2108

patch 9.0.2108: [security]: overflow with count for :s command Commit: https://github.com/vim/vim/commit/ac63787734fda2e294e477af52b3bd601517fa78 Author: Christian Brabandt <cb@256bit.org> Date: Tue Nov 14 20:45:48 2023 +0100 patch 9.0.2108: [security]: overflow with count for :s command Problem: [security]: overflow with count for :s command Solution: Abort the :s command if the count is too large If the count after the :s command is larger than what fits into a (signed) long variable, abort with e_value_too_large. Adds a test with INT_MAX as count and verify it correctly fails. It seems the return value on Windows using mingw compiler wraps around, so the initial test using :s/./b/9999999999999999999999999990 doesn't fail there, since the count is wrapping around several times and finally is no longer larger than 2147483647. So let's just use 2147483647 in the test, which hopefully will always cause a failure Signed-off-by: Christian Brabandt <cb@256bit.org>
author Christian Brabandt <cb@256bit.org>
date Thu, 16 Nov 2023 22:15:10 +0100
parents 4c975fa0a442
children 3f4883e56207
comparison
equal deleted inserted replaced
33775:7109d1c57221 33776:9503dc55b5ed
1 *change.txt* For Vim version 9.0. Last change: 2023 Sep 19 1 *change.txt* For Vim version 9.0. Last change: 2023 Nov 15
2 2
3 3
4 VIM REFERENCE MANUAL by Bram Moolenaar 4 VIM REFERENCE MANUAL by Bram Moolenaar
5 5
6 6
642 special; see |sub-replace-special|. 642 special; see |sub-replace-special|.
643 When [range] and [count] are omitted, replace in the 643 When [range] and [count] are omitted, replace in the
644 current line only. When [count] is given, replace in 644 current line only. When [count] is given, replace in
645 [count] lines, starting with the last line in [range]. 645 [count] lines, starting with the last line in [range].
646 When [range] is omitted start in the current line. 646 When [range] is omitted start in the current line.
647 *E939* 647 *E939* *E1510*
648 [count] must be a positive number. Also see 648 [count] must be a positive number (max 2147483647)
649 |cmdline-ranges|. 649 Also see |cmdline-ranges|.
650 650
651 See |:s_flags| for [flags]. 651 See |:s_flags| for [flags].
652 The delimiter doesn't need to be /, see 652 The delimiter doesn't need to be /, see
653 |pattern-delimiter|. 653 |pattern-delimiter|.
654 654