Mercurial > vim
comparison src/fileio.c @ 12771:8984342ab09e v8.0.1263
patch 8.0.1263: others can read the swap file if a user is careless
commit https://github.com/vim/vim/commit/5a73e0ca54c77e067c3b12ea6f35e3e8681e8cf8
Author: Bram Moolenaar <Bram@vim.org>
Date: Sat Nov 4 21:35:01 2017 +0100
patch 8.0.1263: others can read the swap file if a user is careless
Problem: Others can read the swap file if a user is careless with his
primary group.
Solution: If the group permission allows for reading but the world
permissions doesn't, make sure the group is right.
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Sat, 04 Nov 2017 21:45:04 +0100 |
| parents | 351cf7c67bbe |
| children | 9d51b8c6b84e |
comparison
equal
deleted
inserted
replaced
| 12770:89889fea43e0 | 12771:8984342ab09e |
|---|---|
| 714 #endif | 714 #endif |
| 715 #ifdef UNIX | 715 #ifdef UNIX |
| 716 /* Set swap file protection bits after creating it. */ | 716 /* Set swap file protection bits after creating it. */ |
| 717 if (swap_mode > 0 && curbuf->b_ml.ml_mfp != NULL | 717 if (swap_mode > 0 && curbuf->b_ml.ml_mfp != NULL |
| 718 && curbuf->b_ml.ml_mfp->mf_fname != NULL) | 718 && curbuf->b_ml.ml_mfp->mf_fname != NULL) |
| 719 (void)mch_setperm(curbuf->b_ml.ml_mfp->mf_fname, (long)swap_mode); | 719 { |
| 720 char_u *swap_fname = curbuf->b_ml.ml_mfp->mf_fname; | |
| 721 | |
| 722 /* | |
| 723 * If the group-read bit is set but not the world-read bit, then | |
| 724 * the group must be equal to the group of the original file. If | |
| 725 * we can't make that happen then reset the group-read bit. This | |
| 726 * avoids making the swap file readable to more users when the | |
| 727 * primary group of the user is too permissive. | |
| 728 */ | |
| 729 if ((swap_mode & 044) == 040) | |
| 730 { | |
| 731 stat_T swap_st; | |
| 732 | |
| 733 if (mch_stat((char *)swap_fname, &swap_st) >= 0 | |
| 734 && st.st_gid != swap_st.st_gid | |
| 735 && fchown(curbuf->b_ml.ml_mfp->mf_fd, -1, st.st_gid) | |
| 736 == -1) | |
| 737 swap_mode &= 0600; | |
| 738 } | |
| 739 | |
| 740 (void)mch_setperm(swap_fname, (long)swap_mode); | |
| 741 } | |
| 720 #endif | 742 #endif |
| 721 } | 743 } |
| 722 | 744 |
| 723 #if defined(HAS_SWAP_EXISTS_ACTION) | 745 #if defined(HAS_SWAP_EXISTS_ACTION) |
| 724 /* If "Quit" selected at ATTENTION dialog, don't load the file */ | 746 /* If "Quit" selected at ATTENTION dialog, don't load the file */ |