comparison src/sign.c @ 29175:755ab148288b v8.2.5107

patch 8.2.5107: some callers of rettv_list_alloc() check for not OK Commit: https://github.com/vim/vim/commit/93a1096fe48e12095544924adb267e3b8a16b221 Author: Bram Moolenaar <Bram@vim.org> Date: Thu Jun 16 11:42:09 2022 +0100 patch 8.2.5107: some callers of rettv_list_alloc() check for not OK Problem: Some callers of rettv_list_alloc() check for not OK. (Christ van Willegen) Solution: Use "==" instead of "!=" when checking the return value.
author Bram Moolenaar <Bram@vim.org>
date Thu, 16 Jun 2022 12:45:03 +0200
parents 62cc3b60493b
children 827d9f2b7a71
comparison
equal deleted inserted replaced
29174:a13f0046b5ef 29175:755ab148288b
2333 return; 2333 return;
2334 2334
2335 if (argvars[0].v_type == VAR_LIST && argvars[1].v_type == VAR_UNKNOWN) 2335 if (argvars[0].v_type == VAR_LIST && argvars[1].v_type == VAR_UNKNOWN)
2336 { 2336 {
2337 // Define multiple signs 2337 // Define multiple signs
2338 if (rettv_list_alloc(rettv) != OK) 2338 if (rettv_list_alloc(rettv) == FAIL)
2339 return; 2339 return;
2340 2340
2341 sign_define_multiple(argvars[0].vval.v_list, rettv->vval.v_list); 2341 sign_define_multiple(argvars[0].vval.v_list, rettv->vval.v_list);
2342 return; 2342 return;
2343 } 2343 }
2365 void 2365 void
2366 f_sign_getdefined(typval_T *argvars, typval_T *rettv) 2366 f_sign_getdefined(typval_T *argvars, typval_T *rettv)
2367 { 2367 {
2368 char_u *name = NULL; 2368 char_u *name = NULL;
2369 2369
2370 if (rettv_list_alloc_id(rettv, aid_sign_getdefined) != OK) 2370 if (rettv_list_alloc_id(rettv, aid_sign_getdefined) == FAIL)
2371 return; 2371 return;
2372 2372
2373 if (in_vim9script() && check_for_opt_string_arg(argvars, 0) == FAIL) 2373 if (in_vim9script() && check_for_opt_string_arg(argvars, 0) == FAIL)
2374 return; 2374 return;
2375 2375
2391 linenr_T lnum = 0; 2391 linenr_T lnum = 0;
2392 int sign_id = 0; 2392 int sign_id = 0;
2393 char_u *group = NULL; 2393 char_u *group = NULL;
2394 int notanum = FALSE; 2394 int notanum = FALSE;
2395 2395
2396 if (rettv_list_alloc_id(rettv, aid_sign_getplaced) != OK) 2396 if (rettv_list_alloc_id(rettv, aid_sign_getplaced) == FAIL)
2397 return; 2397 return;
2398 2398
2399 if (in_vim9script() 2399 if (in_vim9script()
2400 && (check_for_opt_buffer_arg(argvars, 0) == FAIL 2400 && (check_for_opt_buffer_arg(argvars, 0) == FAIL
2401 || (argvars[0].v_type != VAR_UNKNOWN 2401 || (argvars[0].v_type != VAR_UNKNOWN
2659 f_sign_placelist(typval_T *argvars, typval_T *rettv) 2659 f_sign_placelist(typval_T *argvars, typval_T *rettv)
2660 { 2660 {
2661 listitem_T *li; 2661 listitem_T *li;
2662 int sign_id; 2662 int sign_id;
2663 2663
2664 if (rettv_list_alloc(rettv) != OK) 2664 if (rettv_list_alloc(rettv) == FAIL)
2665 return; 2665 return;
2666 2666
2667 if (in_vim9script() && check_for_list_arg(argvars, 0) == FAIL) 2667 if (in_vim9script() && check_for_list_arg(argvars, 0) == FAIL)
2668 return; 2668 return;
2669 2669
2719 return; 2719 return;
2720 2720
2721 if (argvars[0].v_type == VAR_LIST && argvars[1].v_type == VAR_UNKNOWN) 2721 if (argvars[0].v_type == VAR_LIST && argvars[1].v_type == VAR_UNKNOWN)
2722 { 2722 {
2723 // Undefine multiple signs 2723 // Undefine multiple signs
2724 if (rettv_list_alloc(rettv) != OK) 2724 if (rettv_list_alloc(rettv) == FAIL)
2725 return; 2725 return;
2726 2726
2727 sign_undefine_multiple(argvars[0].vval.v_list, rettv->vval.v_list); 2727 sign_undefine_multiple(argvars[0].vval.v_list, rettv->vval.v_list);
2728 return; 2728 return;
2729 } 2729 }
2890 f_sign_unplacelist(typval_T *argvars, typval_T *rettv) 2890 f_sign_unplacelist(typval_T *argvars, typval_T *rettv)
2891 { 2891 {
2892 listitem_T *li; 2892 listitem_T *li;
2893 int retval; 2893 int retval;
2894 2894
2895 if (rettv_list_alloc(rettv) != OK) 2895 if (rettv_list_alloc(rettv) == FAIL)
2896 return; 2896 return;
2897 2897
2898 if (in_vim9script() && check_for_list_arg(argvars, 0) == FAIL) 2898 if (in_vim9script() && check_for_list_arg(argvars, 0) == FAIL)
2899 return; 2899 return;
2900 2900