Mercurial > vim
comparison src/regexp.c @ 11267:588de97b40e7 v8.0.0519
patch 8.0.0519: character classes are not well tested
commit https://github.com/vim/vim/commit/0c078fc7db2902d4ccba04506db082ddbef45a8c
Author: Bram Moolenaar <Bram@vim.org>
Date: Wed Mar 29 15:31:20 2017 +0200
patch 8.0.0519: character classes are not well tested
Problem: Character classes are not well tested. They can differ between
platforms.
Solution: Add tests. In the documentation make clear which classes depend
on what library function. Only use :cntrl: and :graph: for ASCII.
(Kazunobu Kuriyama, Dominique Pelle, closes #1560)
Update the documentation.
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Wed, 29 Mar 2017 15:45:05 +0200 |
| parents | f4ea50924c6d |
| children | 121d29004998 |
comparison
equal
deleted
inserted
replaced
| 11266:a506bfde58c6 | 11267:588de97b40e7 |
|---|---|
| 2553 case CLASS_BLANK: | 2553 case CLASS_BLANK: |
| 2554 regc(' '); | 2554 regc(' '); |
| 2555 regc('\t'); | 2555 regc('\t'); |
| 2556 break; | 2556 break; |
| 2557 case CLASS_CNTRL: | 2557 case CLASS_CNTRL: |
| 2558 for (cu = 1; cu <= 255; cu++) | 2558 for (cu = 1; cu <= 127; cu++) |
| 2559 if (iscntrl(cu)) | 2559 if (iscntrl(cu)) |
| 2560 regmbc(cu); | 2560 regmbc(cu); |
| 2561 break; | 2561 break; |
| 2562 case CLASS_DIGIT: | 2562 case CLASS_DIGIT: |
| 2563 for (cu = 1; cu <= 255; cu++) | 2563 for (cu = 1; cu <= 127; cu++) |
| 2564 if (VIM_ISDIGIT(cu)) | 2564 if (VIM_ISDIGIT(cu)) |
| 2565 regmbc(cu); | 2565 regmbc(cu); |
| 2566 break; | 2566 break; |
| 2567 case CLASS_GRAPH: | 2567 case CLASS_GRAPH: |
| 2568 for (cu = 1; cu <= 255; cu++) | 2568 for (cu = 1; cu <= 127; cu++) |
| 2569 if (isgraph(cu)) | 2569 if (isgraph(cu)) |
| 2570 regmbc(cu); | 2570 regmbc(cu); |
| 2571 break; | 2571 break; |
| 2572 case CLASS_LOWER: | 2572 case CLASS_LOWER: |
| 2573 for (cu = 1; cu <= 255; cu++) | 2573 for (cu = 1; cu <= 255; cu++) |