comparison src/window.c @ 34196:57b21d421cb2 v9.1.0048

patch 9.1.0048: Abort opening cmdwin if autocmds screw things up Commit: https://github.com/vim/vim/commit/43b395ec2e7d24a067d7cb00109818b64da144a5 Author: Sean Dewar <seandewar@users.noreply.github.com> Date: Wed Aug 16 16:17:31 2023 +0100 patch 9.1.0048: Abort opening cmdwin if autocmds screw things up Problem: Autocmds triggered from opening the cmdwin (in win_split and do_ecmd) can cause issues such as E199, as the current checks are insufficient. Solution: Commands executed from the cmdwin apply to the old curwin/buf, so they should be kept in a "suspended" state; abort if they've changed. Also abort if cmdwin/buf was tampered with, and check that curwin is correct. Try to clean up the cmdwin buffer (only if hidden and non-current to simplify things; the same approach is used when closing cmdwin normally), and add a beep. (Sean Dewar) It'd be nice to also check that curwin was *really* created by win_split, as autocommands can change curwin before it returns (so it can't be assumed to be that of the split); for now, this means that the cmdwin may not be the botwin in that case, which is probably OK. closes: #12819 Signed-off-by: Sean Dewar <seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
author Christian Brabandt <cb@256bit.org>
date Tue, 23 Jan 2024 23:00:05 +0100
parents a522c6c0127b
children f2d904d44ebd
comparison
equal deleted inserted replaced
34195:5f4e62326459 34196:57b21d421cb2
2483 /* 2483 /*
2484 * Return TRUE if the current window is the only window that exists (ignoring 2484 * Return TRUE if the current window is the only window that exists (ignoring
2485 * "aucmd_win[]"). 2485 * "aucmd_win[]").
2486 * Returns FALSE if there is a window, possibly in another tab page. 2486 * Returns FALSE if there is a window, possibly in another tab page.
2487 */ 2487 */
2488 static int 2488 int
2489 last_window(void) 2489 last_window(void)
2490 { 2490 {
2491 return (one_window() && first_tabpage->tp_next == NULL); 2491 return (one_window() && first_tabpage->tp_next == NULL);
2492 } 2492 }
2493 2493