Mercurial > vim
comparison src/proto/window.pro @ 34196:57b21d421cb2 v9.1.0048
patch 9.1.0048: Abort opening cmdwin if autocmds screw things up
Commit: https://github.com/vim/vim/commit/43b395ec2e7d24a067d7cb00109818b64da144a5
Author: Sean Dewar <seandewar@users.noreply.github.com>
Date: Wed Aug 16 16:17:31 2023 +0100
patch 9.1.0048: Abort opening cmdwin if autocmds screw things up
Problem: Autocmds triggered from opening the cmdwin (in win_split and
do_ecmd) can cause issues such as E199, as the current checks
are insufficient.
Solution: Commands executed from the cmdwin apply to the old curwin/buf,
so they should be kept in a "suspended" state; abort if
they've changed. Also abort if cmdwin/buf was tampered with,
and check that curwin is correct. Try to clean up the cmdwin
buffer (only if hidden and non-current to simplify things; the
same approach is used when closing cmdwin normally), and add a
beep. (Sean Dewar)
It'd be nice to also check that curwin was *really* created by win_split, as
autocommands can change curwin before it returns (so it can't be assumed to be
that of the split); for now, this means that the cmdwin may not be the botwin in
that case, which is probably OK.
closes: #12819
Signed-off-by: Sean Dewar <seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 23 Jan 2024 23:00:05 +0100 |
parents | 7c4ad06d80ec |
children | 37b4c89ba420 |
comparison
equal
deleted
inserted
replaced
34195:5f4e62326459 | 34196:57b21d421cb2 |
---|---|
16 void win_equal(win_T *next_curwin, int current, int dir); | 16 void win_equal(win_T *next_curwin, int current, int dir); |
17 void leaving_window(win_T *win); | 17 void leaving_window(win_T *win); |
18 void entering_window(win_T *win); | 18 void entering_window(win_T *win); |
19 void curwin_init(void); | 19 void curwin_init(void); |
20 void close_windows(buf_T *buf, int keep_curwin); | 20 void close_windows(buf_T *buf, int keep_curwin); |
21 int last_window(void); | |
21 int one_window(void); | 22 int one_window(void); |
22 int win_close(win_T *win, int free_buf); | 23 int win_close(win_T *win, int free_buf); |
23 void snapshot_windows_scroll_size(void); | 24 void snapshot_windows_scroll_size(void); |
24 void may_make_initial_scroll_size_snapshot(void); | 25 void may_make_initial_scroll_size_snapshot(void); |
25 void may_trigger_win_scrolled_resized(void); | 26 void may_trigger_win_scrolled_resized(void); |