Mercurial > vim
comparison src/testdir/test_execute_func.vim @ 34534:239e20a09999 v9.1.0169
patch 9.1.0169: current window number returned by tabpagewinnr may be outdated
Commit: https://github.com/vim/vim/commit/e101028a5c896480c61fef7ea16855255925709b
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Mar 12 20:42:25 2024 +0100
patch 9.1.0169: current window number returned by tabpagewinnr may be outdated
Problem: current window number returned by tabpagewinnr may be outdated
when called from win_execute for the original tabpage.
Solution: update the original tabpage's tp_curwin in switch_win; use
{un}use_tabpage instead. Don't do it in restore_win to ensure
tp_curwin of the temporarily visited tabpage is unchanged from
switch_win visiting it, as before. (Sean Dewar)
Maybe restore_win should only restore tp_curwin if
`curtab == switchwin->sw_curtab`, in case the user changed tabpages from within
win_execute, but not doing that is consistent with the old behaviour.
related: #14186
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 12 Mar 2024 21:00:09 +0100 |
parents | ea38db8639eb |
children |
comparison
equal
deleted
inserted
replaced
34533:c742498564fa | 34534:239e20a09999 |
---|---|
202 call assert_fails('call execute(test_null_job())', 'E908:') | 202 call assert_fails('call execute(test_null_job())', 'E908:') |
203 call assert_fails('call execute(test_null_channel())', 'E908:') | 203 call assert_fails('call execute(test_null_channel())', 'E908:') |
204 endif | 204 endif |
205 endfunc | 205 endfunc |
206 | 206 |
207 func Test_win_execute_tabpagewinnr() | |
208 belowright split | |
209 tab split | |
210 belowright split | |
211 call assert_equal(2, tabpagewinnr(1)) | |
212 | |
213 tabprevious | |
214 wincmd p | |
215 call assert_equal(1, tabpagenr()) | |
216 call assert_equal(1, tabpagewinnr(1)) | |
217 call assert_equal(2, tabpagewinnr(2)) | |
218 | |
219 call win_execute(win_getid(1, 2), | |
220 \ 'call assert_equal(2, tabpagenr())' | |
221 \ .. '| call assert_equal(1, tabpagewinnr(1))' | |
222 \ .. '| call assert_equal(1, tabpagewinnr(2))') | |
223 | |
224 call assert_equal(1, tabpagenr()) | |
225 call assert_equal(1, tabpagewinnr(1)) | |
226 call assert_equal(2, tabpagewinnr(2)) | |
227 | |
228 %bwipe! | |
229 endfunc | |
230 | |
207 " vim: shiftwidth=2 sts=2 expandtab | 231 " vim: shiftwidth=2 sts=2 expandtab |