comparison src/version.c @ 34074:1629cc65d78d v9.1.0006

patch 9.1.0006: is*() and to*() function may be unsafe Commit: https://github.com/vim/vim/commit/184f71cc6868a240dc872ed2852542bbc1d43e28 Author: Keith Thompson <Keith.S.Thompson@gmail.com> Date: Thu Jan 4 21:19:04 2024 +0100 patch 9.1.0006: is*() and to*() function may be unsafe Problem: is*() and to*() function may be unsafe Solution: Add SAFE_* macros and start using those instead (Keith Thompson) Use SAFE_() macros for is*() and to*() functions The standard is*() and to*() functions declared in <ctype.h> have undefined behavior for negative arguments other than EOF. If plain char is signed, passing an unchecked value from argv for from user input to one of these functions has undefined behavior. Solution: Add SAFE_*() macros that cast the argument to unsigned char. Most implementations behave sanely for negative arguments, and most character values in practice are non-negative, but it's still best to avoid undefined behavior. The change from #13347 has been omitted, as this has already been separately fixed in commit ac709e2fc0db6d31abb7da96f743c40956b60c3a (v9.0.2054) fixes: #13332 closes: #13347 Signed-off-by: Keith Thompson <Keith.S.Thompson@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
author Christian Brabandt <cb@256bit.org>
date Thu, 04 Jan 2024 21:30:04 +0100
parents 6d9e20b403e8
children 21fc3f1676be
comparison
equal deleted inserted replaced
34073:7d9c9731e78e 34074:1629cc65d78d
702 NULL 702 NULL
703 }; 703 };
704 704
705 static int included_patches[] = 705 static int included_patches[] =
706 { /* Add new patch number below this line */ 706 { /* Add new patch number below this line */
707 /**/
708 6,
707 /**/ 709 /**/
708 5, 710 5,
709 /**/ 711 /**/
710 4, 712 4,
711 /**/ 713 /**/
1326 { 1328 {
1327 STRCPY(vers, mediumVersion); 1329 STRCPY(vers, mediumVersion);
1328 if (highest_patch()) 1330 if (highest_patch())
1329 { 1331 {
1330 // Check for 9.9x or 9.9xx, alpha/beta version 1332 // Check for 9.9x or 9.9xx, alpha/beta version
1331 if (isalpha((int)vers[3])) 1333 if (SAFE_isalpha((int)vers[3]))
1332 { 1334 {
1333 int len = (isalpha((int)vers[4])) ? 5 : 4; 1335 int len = (SAFE_isalpha((int)vers[4])) ? 5 : 4;
1334 sprintf((char *)vers + len, ".%d%s", highest_patch(), 1336 sprintf((char *)vers + len, ".%d%s", highest_patch(),
1335 mediumVersion + len); 1337 mediumVersion + len);
1336 } 1338 }
1337 else 1339 else
1338 sprintf((char *)vers + 3, ".%d", highest_patch()); 1340 sprintf((char *)vers + 3, ".%d", highest_patch());