comparison src/gui_photon.c @ 34074:1629cc65d78d v9.1.0006

patch 9.1.0006: is*() and to*() function may be unsafe Commit: https://github.com/vim/vim/commit/184f71cc6868a240dc872ed2852542bbc1d43e28 Author: Keith Thompson <Keith.S.Thompson@gmail.com> Date: Thu Jan 4 21:19:04 2024 +0100 patch 9.1.0006: is*() and to*() function may be unsafe Problem: is*() and to*() function may be unsafe Solution: Add SAFE_* macros and start using those instead (Keith Thompson) Use SAFE_() macros for is*() and to*() functions The standard is*() and to*() functions declared in <ctype.h> have undefined behavior for negative arguments other than EOF. If plain char is signed, passing an unchecked value from argv for from user input to one of these functions has undefined behavior. Solution: Add SAFE_*() macros that cast the argument to unsigned char. Most implementations behave sanely for negative arguments, and most character values in practice are non-negative, but it's still best to avoid undefined behavior. The change from #13347 has been omitted, as this has already been separately fixed in commit ac709e2fc0db6d31abb7da96f743c40956b60c3a (v9.0.2054) fixes: #13332 closes: #13347 Signed-off-by: Keith Thompson <Keith.S.Thompson@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
author Christian Brabandt <cb@256bit.org>
date Thu, 04 Jan 2024 21:30:04 +0100
parents 695b50472e85
children
comparison
equal deleted inserted replaced
34073:7d9c9731e78e 34074:1629cc65d78d
975 // Look for '(' digits ')' 975 // Look for '(' digits ')'
976 mark = vim_strchr(menu->dname, '('); 976 mark = vim_strchr(menu->dname, '(');
977 if (mark != NULL) 977 if (mark != NULL)
978 { 978 {
979 mark++; 979 mark++;
980 while (isdigit(*mark)) 980 while (SAFE_isdigit(*mark))
981 mark++; 981 mark++;
982 982
983 if (*mark == ')') 983 if (*mark == ')')
984 return TRUE; 984 return TRUE;
985 } 985 }
2543 PtAddCallback(menu->submenu_id, Pt_CB_UNREALIZED, 2543 PtAddCallback(menu->submenu_id, Pt_CB_UNREALIZED,
2544 gui_ph_handle_menu_unrealized, menu); 2544 gui_ph_handle_menu_unrealized, menu);
2545 2545
2546 if (menu->mnemonic != 0) 2546 if (menu->mnemonic != 0)
2547 { 2547 {
2548 PtAddHotkeyHandler(gui.vimWindow, tolower(menu->mnemonic), 2548 PtAddHotkeyHandler(gui.vimWindow, SAFE_tolower(menu->mnemonic),
2549 Pk_KM_Alt, 0, menu, gui_ph_handle_pulldown_menu); 2549 Pk_KM_Alt, 0, menu, gui_ph_handle_pulldown_menu);
2550 } 2550 }
2551 } 2551 }
2552 2552
2553 gui_ph_position_menu(menu->id, menu->priority); 2553 gui_ph_position_menu(menu->id, menu->priority);
2827 { 2827 {
2828 if (mark != NULL) 2828 if (mark != NULL)
2829 { 2829 {
2830 while (*mark != NUL && *mark++ == ':') 2830 while (*mark != NUL && *mark++ == ':')
2831 { 2831 {
2832 switch (tolower(*mark++)) 2832 switch (SAFE_tolower(*mark++))
2833 { 2833 {
2834 case 'a': *font_flags |= PF_STYLE_ANTIALIAS; break; 2834 case 'a': *font_flags |= PF_STYLE_ANTIALIAS; break;
2835 case 'b': *font_flags |= PF_STYLE_BOLD; break; 2835 case 'b': *font_flags |= PF_STYLE_BOLD; break;
2836 case 'i': *font_flags |= PF_STYLE_ITALIC; break; 2836 case 'i': *font_flags |= PF_STYLE_ITALIC; break;
2837 2837