annotate ci/setup-xvfb.sh @ 34309:d7cfd8fb1d75 v9.1.0089

patch 9.1.0089: qsort() comparison functions should be transitive Commit: https://github.com/vim/vim/commit/e06e43766500ecb4cd1031fa16cf9cbebdb222c1 Author: Christian Brabandt <cb@256bit.org> Date: Fri Feb 9 19:39:14 2024 +0100 patch 9.1.0089: qsort() comparison functions should be transitive Problem: qsort() comparison functions should be transitive Solution: Do not subtract values, but rather use explicit comparisons Improve qsort() comparison functions There has been a recent report on qsort() causing out-of-bounds read & write in glibc for non transitive comparison functions https://www.qualys.com/2024/01/30/qsort.txt Even so the bug is in glibc's implementation of the qsort() algorithm, it's bad style to just use substraction for the comparison functions, which may cause overflow issues and as hinted at in OpenBSD's manual page for qsort(): "It is almost always an error to use subtraction to compute the return value of the comparison function." So check the qsort() comparison functions and change them to be safe. closes: #13980 Signed-off-by: Christian Brabandt <cb@256bit.org>
author Christian Brabandt <cb@256bit.org>
date Fri, 09 Feb 2024 19:45:06 +0100
parents 1984a3fcc953
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
23209
1984a3fcc953 patch 8.2.2150: Github actions CI isn't used for all available platforms
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
1 #!/bin/bash
1984a3fcc953 patch 8.2.2150: Github actions CI isn't used for all available platforms
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
2 set -e
1984a3fcc953 patch 8.2.2150: Github actions CI isn't used for all available platforms
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
3
1984a3fcc953 patch 8.2.2150: Github actions CI isn't used for all available platforms
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
4 apt-get install -y xvfb
1984a3fcc953 patch 8.2.2150: Github actions CI isn't used for all available platforms
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
5
1984a3fcc953 patch 8.2.2150: Github actions CI isn't used for all available platforms
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
6 cat <<EOT >/etc/systemd/system/xvfb.service
1984a3fcc953 patch 8.2.2150: Github actions CI isn't used for all available platforms
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
7 [Unit]
1984a3fcc953 patch 8.2.2150: Github actions CI isn't used for all available platforms
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
8 Description=X Virtual Frame Buffer Service
1984a3fcc953 patch 8.2.2150: Github actions CI isn't used for all available platforms
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
9 After=network.target
1984a3fcc953 patch 8.2.2150: Github actions CI isn't used for all available platforms
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
10 [Service]
1984a3fcc953 patch 8.2.2150: Github actions CI isn't used for all available platforms
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
11 ExecStart=/usr/bin/Xvfb :99 -screen 0 1024x768x24
1984a3fcc953 patch 8.2.2150: Github actions CI isn't used for all available platforms
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
12 [Install]
1984a3fcc953 patch 8.2.2150: Github actions CI isn't used for all available platforms
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
13 WantedBy=multi-user.target
1984a3fcc953 patch 8.2.2150: Github actions CI isn't used for all available platforms
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
14 EOT
1984a3fcc953 patch 8.2.2150: Github actions CI isn't used for all available platforms
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
15
1984a3fcc953 patch 8.2.2150: Github actions CI isn't used for all available platforms
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
16 systemctl enable xvfb.service
1984a3fcc953 patch 8.2.2150: Github actions CI isn't used for all available platforms
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
17 systemctl start xvfb.service