Mercurial > vim
annotate src/alloc.h @ 34686:83875247fbc0 v9.1.0224
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Commit: https://github.com/vim/vim/commit/515f734e687f28f7199b2a8042197624d9f3ec15
Author: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Date: Thu Mar 28 12:01:14 2024 +0100
patch 9.1.0224: cursor may move too many lines over "right" & "below" virt text
Problem: If a line has "right" & "below" virtual text properties,
where the "below" property may be stored first due to lack of
ordering between them, then the line height is calculated to
be 1 more and causes the cursor to far over the line.
Solution: Remove some unnecessary setting of a
`next_right_goes_below = TRUE` flag for "below" and "above"
text properties. (Dylan Thacker-Smith)
I modified a regression test I recently added to cover this case,
leveraging the fact that "after", "right" & "below" text properties are
being stored in the reverse of the order they are added in. The
previous version of this regression test was crafted to workaround this
issue so it can be addressed by this separate patch.
closes: #14317
Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 28 Mar 2024 12:15:03 +0100 |
parents | f24d4826e6bf |
children |
rev | line source |
---|---|
10042
4aead6a9b7a9
commit https://github.com/vim/vim/commit/edf3f97ae2af024708ebb4ac614227327033ca47
Christian Brabandt <cb@256bit.org>
parents:
8269
diff
changeset
|
1 /* vi:set ts=8 sts=4 sw=4 noet: |
7545
4c922651fd78
commit https://github.com/vim/vim/commit/28fb79db6b52d1154e8dc63d227673648c2fce15
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
2 * |
4c922651fd78
commit https://github.com/vim/vim/commit/28fb79db6b52d1154e8dc63d227673648c2fce15
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
3 * VIM - Vi IMproved by Bram Moolenaar |
4c922651fd78
commit https://github.com/vim/vim/commit/28fb79db6b52d1154e8dc63d227673648c2fce15
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
4 * |
4c922651fd78
commit https://github.com/vim/vim/commit/28fb79db6b52d1154e8dc63d227673648c2fce15
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
5 * Do ":help uganda" in Vim to read copying and usage conditions. |
4c922651fd78
commit https://github.com/vim/vim/commit/28fb79db6b52d1154e8dc63d227673648c2fce15
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
6 * Do ":help credits" in Vim to see a list of people who contributed. |
4c922651fd78
commit https://github.com/vim/vim/commit/28fb79db6b52d1154e8dc63d227673648c2fce15
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
7 */ |
4c922651fd78
commit https://github.com/vim/vim/commit/28fb79db6b52d1154e8dc63d227673648c2fce15
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
8 |
4c922651fd78
commit https://github.com/vim/vim/commit/28fb79db6b52d1154e8dc63d227673648c2fce15
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
9 /* |
4c922651fd78
commit https://github.com/vim/vim/commit/28fb79db6b52d1154e8dc63d227673648c2fce15
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
10 * alloc.h: enumeration of alloc IDs. |
27897
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
11 * Used by test_alloc_fail() to test memory allocation failures. |
7545
4c922651fd78
commit https://github.com/vim/vim/commit/28fb79db6b52d1154e8dc63d227673648c2fce15
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
12 * Each entry must be on exactly one line, GetAllocId() depends on that. |
4c922651fd78
commit https://github.com/vim/vim/commit/28fb79db6b52d1154e8dc63d227673648c2fce15
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
13 */ |
4c922651fd78
commit https://github.com/vim/vim/commit/28fb79db6b52d1154e8dc63d227673648c2fce15
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
14 typedef enum { |
27897
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
15 aid_none = 0, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
16 aid_qf_dirname_start, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
17 aid_qf_dirname_now, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
18 aid_qf_namebuf, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
19 aid_qf_module, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
20 aid_qf_errmsg, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
21 aid_qf_pattern, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
22 aid_qf_efm_fmtstr, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
23 aid_qf_efm_fmtpart, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
24 aid_qf_title, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
25 aid_qf_mef_name, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
26 aid_qf_qfline, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
27 aid_qf_qfinfo, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
28 aid_qf_dirstack, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
29 aid_qf_multiline_pfx, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
30 aid_qf_makecmd, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
31 aid_qf_linebuf, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
32 aid_tagstack_items, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
33 aid_tagstack_from, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
34 aid_tagstack_details, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
35 aid_sign_getdefined, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
36 aid_sign_getplaced, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
37 aid_sign_define_by_name, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
38 aid_sign_getlist, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
39 aid_sign_getplaced_dict, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
40 aid_sign_getplaced_list, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
41 aid_insert_sign, |
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
42 aid_sign_getinfo, |
28289
cdaff4db7760
patch 8.2.4670: memory allocation failures for new tab page not tested
Bram Moolenaar <Bram@vim.org>
parents:
28285
diff
changeset
|
43 aid_newbuf_bvars, |
cdaff4db7760
patch 8.2.4670: memory allocation failures for new tab page not tested
Bram Moolenaar <Bram@vim.org>
parents:
28285
diff
changeset
|
44 aid_newwin_wvars, |
cdaff4db7760
patch 8.2.4670: memory allocation failures for new tab page not tested
Bram Moolenaar <Bram@vim.org>
parents:
28285
diff
changeset
|
45 aid_newtabpage_tvars, |
cdaff4db7760
patch 8.2.4670: memory allocation failures for new tab page not tested
Bram Moolenaar <Bram@vim.org>
parents:
28285
diff
changeset
|
46 aid_blob_alloc, |
28382
f24d4826e6bf
patch 8.2.4716: memory allocation failure not tested when defining a function
Bram Moolenaar <Bram@vim.org>
parents:
28289
diff
changeset
|
47 aid_get_func, |
27897
2a2c0958a913
patch 8.2.4474: memory allocation failures not tested in quickfix code
Bram Moolenaar <Bram@vim.org>
parents:
15209
diff
changeset
|
48 aid_last |
7545
4c922651fd78
commit https://github.com/vim/vim/commit/28fb79db6b52d1154e8dc63d227673648c2fce15
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
49 } alloc_id_T; |