annotate .github/workflows/label.yml @ 33815:08f9e1eac4cf v9.0.2123

patch 9.0.2123: Problem with initializing the length of range() lists Commit: https://github.com/vim/vim/commit/df63da98d8dc284b1c76cfe1b17fa0acbd6094d8 Author: Christian Brabandt <cb@256bit.org> Date: Thu Nov 23 20:14:28 2023 +0100 patch 9.0.2123: Problem with initializing the length of range() lists Problem: Problem with initializing the length of range() lists Solution: Set length explicitly when it shouldn't contain any items range() may cause a wrong calculation of list length, which may later then cause a segfault in list_find(). This is usually not a problem, because range_list_materialize() calculates the length, when it materializes the list. In addition, in list_find() when the length of the range was wrongly initialized, it may seem to be valid, so the check for list index out-of-bounds will not be true, because it is called before the list is actually materialized. And so we may eventually try to access a null pointer, causing a segfault. So this patch does 3 things: - In f_range(), when we know that the list should be empty, explicitly set the list->lv_len value to zero. This should happen, when start is larger than end (in case the stride is positive) or end is larger than start when the stride is negative. This should fix the underlying issue properly. However, - as a safety measure, let's check that the requested index is not out of range one more time, after the list has been materialized and return NULL in case it suddenly is. - add a few more tests to verify the behaviour. fixes: #13557 closes: #13563 Co-authored-by: Tim Pope <tpope@github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
author Christian Brabandt <cb@256bit.org>
date Thu, 23 Nov 2023 20:30:07 +0100
parents 27ce9b18f1d5
children b1e48fed6e55
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
32879
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
1 # This workflow will triage pull requests and apply a label based on the
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
2 # paths that are modified in the pull request.
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
3 #
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
4 # To use this workflow, you will need to set up a .github/labeler.yml
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
5 # file with configuration. For more information, see:
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
6 # https://github.com/actions/labeler
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
7
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
8 name: Labeler
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
9 on: [pull_request_target]
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
10
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
11 jobs:
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
12 label:
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
13
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
14 runs-on: ubuntu-latest
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
15 permissions:
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
16 contents: read
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
17 pull-requests: write
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
18
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
19 steps:
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
20 - uses: actions/labeler@v4
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
21 with:
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
22 repo-token: "${{ secrets.GITHUB_TOKEN }}"
32884
27ce9b18f1d5 patch 9.0.1751: CI: labeler configuration not found
Christian Brabandt <cb@256bit.org>
parents: 32879
diff changeset
23 configuration-path: .github/labeler.yml
32879
49e4d7aa402c patch 9.0.1748: CI: cannot label issues automatically
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
24 sync-labels: ''